Re: [PATCH 00/51] rtc: stop using rtc deprecated functions
From: Alexandre Belloni <hidden>
Date: 2017-06-20 10:08:03
Also in:
linux-arm-kernel, linux-pm, linux-rtc, linux-tegra, lkml
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote:
On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote:quoted
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016.Please don't, because this hide the fact that the hardware will not handle dates in y2038 anyway and as pointed by Russell a few month ago, rtc_time_to_tm will be able to catch it but the 64 bit version will silently ignore it.
Just to be clear, it is fine on your ST hardware because it uses a 64bit counter. Most of the one you patched are using 32 bit counters and so will break anyway.
quoted
The goal of this series of patches is ti stop using those two functions and use instead to safer 64bits ones. It also remove change .set_mmss to set_mmss64 callback for the same reasons. Those 51 patches almost clean all the drivers except the few that I haven't been able to compile because of cross-toolchains issues (au1xxx, mpc5121, ps3, puv3, sun4v, tx4939, starfire, ls1x ...) Obviously I don't have all those hardwares in my hands so I have only check that the patches compile without warnings but it up to each maintainer to valid them on real hardware. Benjamin Gaignard (51): x86: rtc: stop using rtc deprecated functions x86: intel-mid: vrtc: stop using rtc deprecated functions net: broadcom: stop using rtc deprecated functions rtc: 88pm80x: stop using rtc deprecated functions rtc: 88pm860x: stop using rtc deprecated functions rtc: ab-b5ze-s3: stop using rtc deprecated functions rtc: ab8500: stop using rtc deprecated functions rtc: armada38x: stop using rtc deprecated functions rtc: at32ap700x: stop using rtc deprecated functions rtc: at91sam9: stop using rtc deprecated functions rtc: bfin: stop using rtc deprecated functions rtc: coh901331: stop using rtc deprecated functions rtc: cpcap: stop using rtc deprecated functions rtc: da9063: stop using rtc deprecated functions rtc: da9063: stop using rtc deprecated functions rtc: davinci: stop using rtc deprecated functions rtc: digicolor: stop using rtc deprecated functions rtc: dm355evm: stop using rtc deprecated functions rtc: ds1305: stop using rtc deprecated functions rtc: ds1374: stop using rtc deprecated functions rtc: ds1511: stop using rtc deprecated functions rtc: ds1553: stop using rtc deprecated functions rtc: ds1672: stop using rtc deprecated functions rtc: ds2404: stop using rtc deprecated functions rtc: ep93xx: stop using rtc deprecated functions rtc: gemini: stop using rtc deprecated functions rtc: imxdi: stop using rtc deprecated functions rtc: jz4740: stop using rtc deprecated functions rtc: lpc32xx: stop using rtc deprecated functions rtc: mv: stop using rtc deprecated functions rtc: omap: stop using rtc deprecated functions rtc: pcap: stop using rtc deprecated functions rtc: pl030: stop using rtc deprecated functions rtc: pl031: stop using rtc deprecated functions rtc: pm8xxx: stop using rtc deprecated functions rtc: rs5c348: stop using rtc deprecated functions rtc: sa1100: stop using rtc deprecated functions rtc: sh: stop using rtc deprecated functions rtc: sirfsoc: stop using rtc deprecated functions rtc: snvs: stop using rtc deprecated functions rtc: stk17ta8: stop using rtc deprecated functions rtc: stmp3xxx: stop using rtc deprecated functions rtc: sun6i: stop using rtc deprecated functions rtc: sysfs: stop using rtc deprecated functions rtc: tegra stop using rtc deprecated functions rtc: test: stop using rtc deprecated functions rtc: tps6586: stop using rtc deprecated functions rtc: vr41xx: stop using rtc deprecated functions rtc: wm831x: stop using rtc deprecated functions rtc: xgene stop using rtc deprecated functions power: suspend test: stop using rtc deprecated functions arch/x86/kernel/rtc.c | 6 ++-- arch/x86/platform/intel-mid/intel_mid_vrtc.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/rtc/rtc-88pm80x.c | 44 +++++++++++++-------------- drivers/rtc/rtc-88pm860x.c | 40 ++++++++++++------------- drivers/rtc/rtc-ab-b5ze-s3.c | 45 ++++++++-------------------- drivers/rtc/rtc-ab8500.c | 26 ++++++++-------- drivers/rtc/rtc-armada38x.c | 34 +++++++++------------ drivers/rtc/rtc-at32ap700x.c | 29 ++++++++---------- drivers/rtc/rtc-at91sam9.c | 18 ++++------- drivers/rtc/rtc-bfin.c | 24 +++++++-------- drivers/rtc/rtc-coh901331.c | 14 +++++---- drivers/rtc/rtc-cpcap.c | 8 ++--- drivers/rtc/rtc-da9052.c | 8 ++--- drivers/rtc/rtc-da9063.c | 8 ++--- drivers/rtc/rtc-davinci.c | 8 ++--- drivers/rtc/rtc-digicolor.c | 4 +-- drivers/rtc/rtc-dm355evm.c | 6 ++-- drivers/rtc/rtc-ds1305.c | 11 +++---- drivers/rtc/rtc-ds1374.c | 6 ++-- drivers/rtc/rtc-ds1511.c | 2 +- drivers/rtc/rtc-ds1553.c | 2 +- drivers/rtc/rtc-ds1672.c | 8 ++--- drivers/rtc/rtc-ds2404.c | 8 ++--- drivers/rtc/rtc-ep93xx.c | 10 +++---- drivers/rtc/rtc-gemini.c | 8 ++--- drivers/rtc/rtc-imxdi.c | 16 +++++----- drivers/rtc/rtc-jz4740.c | 12 ++++---- drivers/rtc/rtc-lpc32xx.c | 19 +++++------- drivers/rtc/rtc-mv.c | 2 +- drivers/rtc/rtc-omap.c | 6 ++-- drivers/rtc/rtc-pcap.c | 16 +++++----- drivers/rtc/rtc-pl030.c | 24 +++++++-------- drivers/rtc/rtc-pl031.c | 31 ++++++++----------- drivers/rtc/rtc-pm8xxx.c | 22 +++++++------- drivers/rtc/rtc-rs5c348.c | 4 +-- drivers/rtc/rtc-sa1100.c | 25 +++++++--------- drivers/rtc/rtc-sh.c | 2 +- drivers/rtc/rtc-sirfsoc.c | 18 +++++------ drivers/rtc/rtc-snvs.c | 14 ++++----- drivers/rtc/rtc-stk17ta8.c | 2 +- drivers/rtc/rtc-stmp3xxx.c | 12 ++++---- drivers/rtc/rtc-sun6i.c | 14 ++++----- drivers/rtc/rtc-sysfs.c | 25 ++++++++-------- drivers/rtc/rtc-tegra.c | 22 +++++++------- drivers/rtc/rtc-test.c | 17 +---------- drivers/rtc/rtc-tps6586x.c | 26 ++++++++-------- drivers/rtc/rtc-vr41xx.c | 6 ++-- drivers/rtc/rtc-wm831x.c | 28 +++++++---------- drivers/rtc/rtc-xgene.c | 12 ++++---- kernel/power/suspend_test.c | 6 ++-- 51 files changed, 342 insertions(+), 420 deletions(-) -- CC: adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org CC: Alessandro Zummo <redacted> CC: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> CC: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> CC: Ingo Molnar <redacted> CC: Jason Cooper <redacted> CC: John Stultz <redacted> CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: Linus Walleij <redacted> CC: Michael Chan <michael.chan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> CC: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org CC: Sebastian Hesselbarth <redacted> CC: Support Opensource <redacted> CC: Thomas Gleixner <redacted> CC: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org CC: Baruch Siach <redacted> CC: Hans Ulli Kroll <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> CC: Vladimir Zapolskiy <redacted> CC: Sylvain Lemieux <redacted> CC: Barry Song <redacted> CC: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> CC: Chen-Yu Tsai <redacted> CC: Thierry Reding <redacted> CC: Jonathan Hunter <redacted> CC: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org CC: "Rafael J. Wysocki" <redacted> CC: Pavel Machek <redacted> CC: Len Brown <redacted> CC: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org 1.9.1-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.