Re: Odd use of %14pM in net/batman-adv/distributed-arp-table.c | netdev | Ratatoskr

Odd use of %14pM in net/batman-adv/distributed-arp-table.c · Joe Perches <joe@perches.com> · 2017-06-13
Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c · Sven Eckelmann <sven@narfation.org> · 2017-06-14
Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c · Joe Perches <joe@perches.com> · 2017-06-14
[PATCH] batman-adv: Remove unnecessary length qualifier in %14pM · Joe Perches <joe@perches.com> · 2017-06-14
Re: [PATCH] batman-adv: Remove unnecessary length qualifier in %14pM · David Miller <davem@davemloft.net> · 2017-06-14
Re: [PATCH] batman-adv: Remove unnecessary length qualifier in %14pM · Sven Eckelmann <sven@narfation.org> · 2017-06-14

Re: Odd use of %14pM in net/batman-adv/distributed-arp-table.c

From: Joe Perches <hidden>
Date: 2017-06-14 09:33:22
Also in: batman, lkml

On Wed, 2017-06-14 at 10:23 +0200, Sven Eckelmann wrote:

On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote:

quoted

An output mac address is 17 bytes

[...]

quoted

but in net/batman-adv/distributed-arp-table.c

[...]

quoted

%14pM is odd as this should not emit the last byte of the
mac address.  So given the example above, it would output
00:11:22:33:44

[...]

I completely agree too the "wrong length" part. It is currently not omitting 
the last byte:

Right, I only looked at vsprintf.c and mistook precision for
field_width.

Do you want to provide a patch to convert it to simple %pM's?

OK.