Hi Andrew,

-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch]
Sent: Saturday, June 10, 2017 5:36 PM
To: Mintz, Yuval
Cc: Salil Mehta; davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode;
lipeng (Y); mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; Linuxarm
Subject: Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs
interface to HNS3 driver

On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote:

quoted

quoted

This adds the support of the debugfs interface to the driver for

debugging

quoted

quoted

purposes.

quoted

+const struct  hclge_support_cmd  support_cmd[] = {
+	{"send cmd", 8, hclge_dbg_send,
+		"opcode flag data0 data1 data2 data3 data4 data5"},
+	{"help", 4, hclge_dbg_usage, "no option"}, };

Is there an actual description of what this does? Or is it simply a

huge backdoor?

It looks like a huge backdoor to the chip.

It is O.K. to have such a patch internally for your own development
work, but it should not be submitted for mainline.

NACK

	Andrew

I will drop this debugfs patch for now.

Thanks
Salil