Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies
flat view
From: Randy Dunlap <rdunlap@infradead.org>
Date: 2017-06-13 15:45:35
Also in:
lkml
On 06/12/17 17:18, Florian Fainelli wrote:
After commit 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") we could create a configuration where MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined references: drivers/built-in.o: In function `thunder_mdiobus_pci_remove':quoted
quoted
mdio-thunder.c:(.text+0x2a212f): undefined reference to `mdiobus_unregister' mdio-thunder.c:(.text+0x2a2138): undefined reference to `mdiobus_free'drivers/built-in.o: In function `thunder_mdiobus_pci_probe': mdio-thunder.c:(.text+0x2a22e7): undefined reference to `devm_mdiobus_alloc_size' mdio-thunder.c:(.text+0x2a236f): undefined reference to `of_mdiobus_register' Reported-by: kbuild test robot <redacted> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org> Thanks.
quoted hunk ↗ jump to hunk
--- drivers/net/phy/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index c360dd6ead22..3ab6c58d4be6 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig@@ -127,6 +127,7 @@ config MDIO_THUNDER tristate "ThunderX SOCs MDIO buses" depends on 64BIT depends on PCI + depends on !(MDIO_DEVICE=y && PHYLIB=m) select MDIO_CAVIUM help This driver supports the MDIO interfaces found on Cavium
-- ~Randy