Re: [PATCH] i40evf: remove redundant null check on key
flat view
From: Dan Carpenter <hidden>
Date: 2017-06-10 11:34:13
Also in:
intel-wired-lan, kernel-janitors, lkml
This patch isn't right... On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote:
From: Colin Ian King <redacted> key has previously been null checked so the subsequent null check is redundant as key can never be null at that point, so remove it.
Actually, it's the reverse. "key" is always NULL. Probably the || should be a &&? regards, dan carpenter