Thread (11 messages) 11 messages, 3 authors, 2017-06-09

Re: [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing

flat view

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-06-09 13:16:18
Also in: lkml

On Thu, Jun 08, 2017 at 06:34:08PM -0400, Vivien Didelot wrote:
The mv888e6xxx driver accesses a port's netdev mostly for printing.

This is bad for 2 reasons: DSA and CPU ports do not have a netdev
pointer; it doesn't give us a correct picture of why a DSA driver might
need to access a port's netdev.

Instead simply use dev_* printing functions with chip->dev (or ds->dev
depending on the scope, both guaranteed to exist), with a p%d prefix for
the target port.

Signed-off-by: Vivien Didelot <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help