Thread (4 messages) 4 messages, 2 authors, 2017-06-09

Re: [PATCH] af_unix: Add sockaddr length checks before accessing sa_family in bind and connect handlers

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-06-08 20:04:28
Also in: lkml

From: Mateusz Jurczyk <redacted>
Date: Thu,  8 Jun 2017 11:13:36 +0200
Verify that the caller-provided sockaddr structure is large enough to
contain the sa_family field, before accessing it in bind() and connect()
handlers of the AF_UNIX socket. Since neither syscall enforces a minimum
size of the corresponding memory region, very short sockaddrs (zero or
one byte long) result in operating on uninitialized memory while
referencing .sa_family.

Signed-off-by: Mateusz Jurczyk <redacted>
The sockaddr comes from a structure on the caller's kernel stack, even
if the user gives a smaller length, it is legal to access that memory.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help