Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier expectations

On 08/06/17 03:43, Alexei Starovoitov wrote:

On Wed, Jun 07, 2017 at 04:00:02PM +0100, Edward Cree wrote:

quoted

Some of the verifier's error messages have changed, and some constructs
 that previously couldn't be verified are now accepted.

Signed-off-by: Edward Cree <ecree-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
---
 tools/testing/selftests/bpf/test_verifier.c | 226 ++++++++++++++--------------
 1 file changed, 116 insertions(+), 110 deletions(-)

imo this rewrite needs more than one additional test.
Like i counted at least 2 new verifier features (like negative and ptr & 0x40)
All the new logic needs to be covered by tests.

Yes, I will write some new tests to cover the new features.  I just wanted
 to get some comments on the patch first, in case I was barking up entirely
 the wrong tree.

-Ed