RE: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

On Thu, Jun 08, 2017 at 06:31:01AM +0000, Grumbach, Emmanuel wrote:

quoted

Hi,

Hi,

quoted

True, OTOH we need tid to be 8 sometimes. We *just* need to make sure
that we don't index tid_data with this. Hence I think the proper fix is:

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c

b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
index 06ac3f1..16a8646 100644

--- a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c

@@ -1190,11 +1190,11 @@ void iwlagn_rx_reply_tx(struct iwl_priv *priv,

struct iwl_rx_cmd_buffer *rxb)

quoted

                                next_reclaimed;
                        IWL_DEBUG_TX_REPLY(priv, "Next reclaimed packet:%d\n",
                                                  next_reclaimed);
+                       iwlagn_check_ratid_empty(priv, sta_id, tid);
                }

                iwl_trans_reclaim(priv->trans, txq_id, ssn, &skbs);

-               iwlagn_check_ratid_empty(priv, sta_id, tid);
                freed = 0;

                /* process frames */

I can confirm it works. You can add my Tested-By.

Patch in review in our internal tree. It'll be upstreamed through the regular process.
Thanks for your report and debug work.