Thread (14 messages) 14 messages, 3 authors, 2017-06-07

Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-06-07 19:00:38
Also in: lkml

From: Vivien Didelot <redacted>
Date: Tue,  6 Jun 2017 16:56:29 -0400
quoted hunk ↗ jump to hunk
@@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
 	bitmap_zero(members, ds->num_ports);
 	if (ds->index == info->sw_index)
 		set_bit(info->port, members);
+	for (port = 0; port < ds->num_ports; ++port)
+		if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
+			set_bit(port, members);
Please use the more canonical "x++" post-increment in the for() statement.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help