Thread (2 messages) 2 messages, 2 authors, 2017-06-06

Re: [PATCH] net: stmmac: fix a broken u32 less than zero check

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-06-06 20:27:25
Also in: kernel-janitors, lkml

From: Colin King <redacted>
Date: Tue,  6 Jun 2017 14:10:49 +0100
From: Colin Ian King <redacted>

The check that queue is less or equal to zero is always true
because queue is a u32; queue is decremented and will wrap around
and never go -ve. Fix this by making queue an int.

Detected by CoverityScan, CID#1428988 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <redacted>
Applied, thanks Colin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help