Thread (3 messages) 3 messages, 3 authors, 2017-06-06

Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-06-06 19:14:39
Also in: kernel-janitors, lkml

From: Colin King <redacted>
Date: Mon,  5 Jun 2017 10:04:52 +0100
From: Colin Ian King <redacted>

The current comparison of entry < 0 will never be true since entry is an
unsigned integer. Make entry an int to ensure -ve error return values
from the call to jumbo_frm are correctly being caught.

Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")

Signed-off-by: Colin Ian King <redacted>
I know Julia asked for more comments, but I'm going to apply this
as-is for now as it is correct.

Thanks Colin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help