Thread (3 messages) 3 messages, 2 authors, 2017-06-02

Re: [PATCH] net: phy: marvell: make two functions static

flat view

From: Colin Ian King <hidden>
Date: 2017-06-02 14:04:13
Also in: kernel-janitors, lkml

On 02/06/17 15:00, Andrew Lunn wrote:
On Fri, Jun 02, 2017 at 12:14:24PM +0100, Colin King wrote:
quoted
From: Colin Ian King <redacted>

functions m88e1510_get_temp_critical and m88e1510_get_temp_alarm can be
made static as they not need to be in global scope.

Cleans up sparse warnings:
 "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
 "symbol 'm88e1510_get_temp_critical' was not declared. Should it be 
  static?"
Hi Colin

What about m88e1510_get_temp_alarm()? That should also have a static.
Ah, good point, I somehow missed that one. I'll send a V2

Colin
Thanks
     Andrew
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help