Re: [PATCH v4 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

From
Andy Shevchenko <hidden>
Date
2017-06-02 10:43:54
Also in
lkml
Reply to
Jan Kiszka, 2017-06-02
On Fri, Jun 2, 2017 at 10:34 AM, Jan Kiszka [off-list ref] wrote:
Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.
quoted hunk ↗ jump to hunk
+static const struct stmmac_pci_func_data galileo_stmmac_func_data[] = {
        {
                .func = 6,
                .phy_addr = 1,
        },
+       { },
Now this is redundant.
+};
quoted hunk ↗ jump to hunk
+static const struct stmmac_pci_dmi_data galileo_stmmac_dmi_data = {
+       .func = galileo_stmmac_func_data,
+       .nfuncs = ARRAY_SIZE(galileo_stmmac_func_data),
It will be 2, when is supposed to be 1, see above.
+};
+static const struct stmmac_pci_func_data iot2040_stmmac_func_data[] = {
+       { },
+};
+       .nfuncs = ARRAY_SIZE(iot2040_stmmac_func_data),
Ditto.

-- 
With Best Regards,
Andy Shevchenko
Thread (9 messages) 9 messages, 2 authors, 2017-06-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help