Thread (9 messages) 9 messages, 2 authors, 2017-06-01

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

flat view

From: Cyril Hrubis <chrubis@suse.cz>
Date: 2017-06-01 20:03:21
Also in: lkml

Hi!
Thank you very much! I have a wild guess that, when we
have a train of skbs on the error queue starting from a local error,
we will see this issue.

Ping (without my patch) considers EAGAIN on a normal read as an
indication that there is nothing on the error queue, but that's a
flawed assumption.

Would you mind trying another shot in the darkness please? Thanks!
This patch seems to fix the issue, I've tried several times and poll()
just timeouts, haven't seen a single POLLERR in the ping strace.

You can add my Tested-by: for this patch as well :-).

-- 
Cyril Hrubis
chrubis@suse.cz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help