-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, June 29, 2017 11:28 AM
To: gerlitz.or@gmail.com
Cc: Tantilov, Emil S <redacted>; Kirsher, Jeffrey T
[off-list ref]; Greenwalt, Paul [off-list ref];
netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
jogreene@redhat.com
Subject: Re: [net-next v2 6/6] ixgbe: Add malicious driver detection
support

From: Or Gerlitz <redacted>
Date: Wed, 28 Jun 2017 17:28:59 +0300

quoted

On Wed, Jun 28, 2017 at 1:14 AM, Tantilov, Emil S
[off-list ref] wrote:

quoted

Mainly because I am not sure that other (non-Intel) drivers will benefit

from

quoted

quoted

such an option. In normal operation this functionality should not cause

issues

quoted

quoted

and if it doesn't we may be able to deprecate the private flag in the

future.

quoted

If you think this functionality makes sense any driver running over HW
implementing
it would like to be able to expose that and hence you better not use
private flag.

As I mentioned I don't know if this will be useful for other drivers.
The i40e driver enables it by default without possibility to disable it
and if this protection does not cause problems for ixgbe then we may not
need the option in the future. Because of this I wasn't sure if it's
worth polluting the tools with options that may end up not being 
needed/used at all.
 

quoted

Are we sure the trust UAPI can't be extended for that matter?

Yeah, we should probably make this a generic control if possible.

MDD is set globally for the device, while the trusted option is set per VF.
So if we do end up adding an option it probably won't work as extension for
trusted.

Thanks,
Emil