Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

On Thu, Jun 29, 2017 at 05:31:22PM +0300, Or Gerlitz wrote:

On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman
[off-list ref] wrote:

quoted

+       /* Populate IPv4 frame. */
+       frame->reserved = 0;
+       frame->ipv4_src = flow_ipv4->src;
+       frame->ipv4_dst = flow_ipv4->dst;
+       frame->proto = flow_basic->ip_proto;
+       /* Wildcard TOS/TTL as TC can't match them yet. */

FWIW this is wrong... matching on both was added recently

quoted

+       frame->tos = 0;
+       frame->ttl = 0;

note that the same flow dissector matching is used for ipv4 ttl/tos
and ipv6 hoplimit/traffic class

Thanks. I think we'll update the comment for now and make use
of the nice new feature you added in a follow-up patchset.