Thread (7 messages) 7 messages, 3 authors, 2017-06-28

Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

flat view

From: Cong Wang <hidden>
Date: 2017-06-27 16:30:55

On Mon, Jun 26, 2017 at 6:35 PM,  [off-list ref] wrote:
From: Gao Feng <redacted>

When qdisc fail to init, qdisc_create would invoke the destroy callback
to cleanup. But there is no check if the callback exists really. So it
would cause the panic if there is no real destroy callback like these
qdisc codel, pfifo, pfifo_fast, and so on.

Now add one the check for destroy to avoid the possible panic.

Signed-off-by: Gao Feng <redacted>
Looks good,

Acked-by: Cong Wang <redacted>

This is introduced by commit 87b60cfacf9f17cf71933c6e33b.
Please add proper Fixes tag next time.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help