Thread (30 messages) 30 messages, 6 authors, 2017-06-27

Re: [RFC PATCH net-next 1/3] ethtool: Add link down reason callback

flat view

From: Gal Pressman <hidden>
Date: 2017-06-22 10:33:30

quoted
+	ETHTOOL_LINK_PWR_BUDGET_EXC, /* Power budget exceeded */
+	ETHTOOL_LINK_MODULE_ADMIN_DOWN, /* Module admin down */
+
+	ETHTOOL_LINK_REASONS_COUNT
+};
Any enumerated list is going to get changed too often.
Could the API just return a string?
The motivation for the enumerated list is to make this API as generic as possible and compatible
with all ethernet drivers.

Returning a string is a good idea, maybe change the vendor specific opcode to a string?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help