Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

On 06/21/2017 02:39 PM, David Miller wrote:

From: Nathan Fontenot <redacted>
Date: Tue, 20 Jun 2017 17:21:54 -0400

quoted

Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)

I'm incredibly curious where you got the idea to put the Fixes: tag
at the beginning of the commit message.

I have no excuse. As you mentioned I should have looked at what others
had done when using the Fixes.

Would you like me to re-send with the Fixes tag corrected?

-Nathan

Have you seen anyone else submitting patches on netdev do this?

It helps to operate by example, and look at how other people do
things.

The correct location for the Fixes: tag is at the beginning of the
singoffs and acks at the end of the commit message.

There shall be no empty lines between the Fixes: tag and those
signoffs and acks.

Thank you.