Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI
flat view
From: Jason Gunthorpe <hidden>
Date: 2017-06-21 16:33:23
Also in:
linux-rdma
Possibly related (same subject, not in this thread)
- 2017-06-22 · Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI · Leon Romanovsky <hidden>
- 2017-06-21 · RE: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI · Tung, Chien Tin <hidden>
On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote:
quoted hunk ↗ jump to hunk
RDMA_NL_IWCM, RDMA_NL_RSVD, RDMA_NL_LS, /* RDMA Local Services */ + /* + * RDMA_NL_I40IW not in use and it was added here by mistake, + * but we need to keep it anyway, because it is UAPI and for + * unknown reasons, someone in the field decided to replace "5" + * with this define. + */ RDMA_NL_I40IW,
Since this doesn't do anything, never did anything, I think you should just delete it. Anything in userspace that refers to this name is unconditionally broken and a compile failure is the better choice. Jason