Thread (10 messages) 10 messages, 5 authors, 2017-06-20

Re: [PATCH net-next 0/1] Introduction of the tc tests

flat view

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-06-20 05:40:40

On Mon, 19 Jun 2017 23:48:19 -0400 (EDT)
David Miller [off-list ref] wrote:
From: Cong Wang <redacted>
Date: Mon, 19 Jun 2017 16:37:29 -0700
quoted
Hi,

On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates [off-list ref] wrote:  
quoted
Apologies for sending this as one big patch. I've been sitting on this a little
too long, but it's ready and I wanted to get it out.

There are a limited number of tests to start - I plan to add more on a regular
basis.

Lucas Bates (1):
  selftests: Introduce tc testsuite  
Nice work!

Is there any particular reason you want to put these tests in kernel tree
especially tools/testing/selftests/ ?  
Yeah, it would be absolutely terrible if we had more tests in the
kernel selftests area for networking.

More seriously, we need more, not less, tests in the kernel networking
selftests directory.

It doesn't belong in iproute2 because we want a place to put things
that automatically get tested when someone makes kernel changes and
can be integrated into the kernel development workflow.

I want as many tests as possible under there, so I'm really surprised
that you're asking "why" tests are being added there.
The "Occum's razor" for deciding where tests belong should be does
the test need to change to respond to kernel change? Don't want to have
iproute2 tests that have if (kernel_version > ...)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help