Thread (27 messages) 27 messages, 4 authors, 2017-06-17

Re: [PATCH net-next 02/21] udp: call dst_hold_safe() in udp_sk_rx_set_dst()

flat view

From: Wei Wang <hidden>
Date: 2017-06-16 19:06:43

On Fri, Jun 16, 2017 at 12:02 PM, David Miller [off-list ref] wrote:
From: Wei Wang <redacted>
Date: Fri, 16 Jun 2017 10:47:25 -0700
quoted
+     if (dst)
+             /* set noref for now.
+              * any place which wants to hold dst has to call
+              * dst_hold_safe()
+              */
+             skb_dst_set_noref(skb, dst);
You must enclose the code in curly braces if you want to put a comment
in this one-line basic block of the 'if' statement.

Otherwise it's hard to read.

Likewise for the other similar change in this file.
Got it. Will update in the next version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help