Re: [RFC 3/3] networking: make skb_push & __skb_push return void pointers

From
Johannes Berg <johannes@sipsolutions.net>
Date
2017-06-16 09:24:55
Reply to
Joe Perches, 2017-06-16
On Fri, 2017-06-16 at 02:19 -0700, Joe Perches wrote:
quoted
 			if (frag_size  ==
PN533_CMD_DATAFRAME_MAXLEN)
-				*skb_push(frag, sizeof(u8)) =
-							(PN533_CMD
_MI_MASK | 1);
-			else
-				*skb_push(frag, sizeof(u8)) =  1;
/* TG */
+				*(u8 *)skb_push(frag, sizeof(u8))
=
+									
(PN533_CMD_MI_MASK | 1);
+				else
+					*(u8 *)skb_push(frag,
sizeof(u8)) =  1; /* TG */
Can you check all the if/else uses.
This one is not formatted correctly.
I didn't look at any others.
Hmm, that's annoying. I did fix up a few, but I guess I missed this
one.

johannes
Thread (11 messages) 11 messages, 3 authors, last reply 2017-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help