RE: [PATCH net-next 00/11] skb_put_zero() used to optimize code

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of Johannes Berg
Sent: Thursday, June 15, 2017 12:32 AM
To: cugyly@163.com; netdev@vger.kernel.org
Cc: David S . Miller; YUAN Linyu
Subject: Re: [PATCH net-next 00/11] skb_put_zero() used to optimize code

On Wed, 2017-06-14 at 18:29 +0200, Johannes Berg wrote:

quoted

On Wed, 2017-06-14 at 23:00 +0800, yuan linyu wrote:

quoted

sorry, I do them by hand.

oh, ok.

This seems to work:

@@
identifier p;
expression len;
expression skb;
type t;
@@
-p = (t)skb_put(skb, len);
-memset(p, 0, len);
+p = (t)skb_put_zero(skb, len);

Nope, still didn't find everything - not the batman and atm cases for
example. But still a few more, I think that you didn't find, e.g. in
mac80211.

Yes, I thought you already done in mac80211

Anyway - I think none of this is really critical.

johannes