Thread (9 messages) 9 messages, 6 authors, 2017-06-12

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

flat view

From: David Ahern <hidden>
Date: 2017-06-10 23:32:35

On 6/10/17 2:30 PM, Donald Sharp wrote:
This patch fixes two issues:

1) When forwarding on *,G mroutes that are in a vrf, the
kernel was dropping information about the actual incoming
interface when calling ip_mr_forward from ip_mr_input.
This caused ip_mr_forward to send the multicast packet
back out the incoming interface.  Fix this by
modifying ip_mr_forward to be handed the correctly
resolved dev.

2) When a unresolved cache entry is created we store
the incoming skb on the unresolved cache entry and
upon mroute resolution from the user space daemon,
we attempt to forward the packet.  Again we were
not resolving to the correct incoming device for
a vrf scenario, before calling ip_mr_forward.
Fix this by resolving to the correct interface
and calling ip_mr_forward with the result.

Fixes: e58e41596811 ("net: Enable support for VRF with ipv4 multicast")
Signed-off-by: Donald Sharp <redacted>
---
v2: Fixed title
v3: Addressed Review comments by Andrew Lunn and David Ahern
LGTM.

Acked-by: David Ahern <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help