Thread (6 messages) 6 messages, 3 authors, 2017-06-08

Re: [PATCH v2 2/2] net: emac: fix and unify emac_mdio functions

flat view

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-06-07 14:14:28

On Wed, Jun 07, 2017 at 03:51:16PM +0200, Christian Lamparter wrote:
emac_mdio_read_link() was not copying the requested phy settings
back into the emac driver's own phy api. This has caused a link
speed mismatch issue for the AR8035 as the emac driver kept
trying to connect with 10/100MBps on a 1GBit/s link.

This patch also unifies shared code between emac_setup_aneg()
and emac_mdio_setup_forced(). And furthermore it removes
a chunk of emac_mdio_init_phy(), that was copying the same
data into itself.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help