[patch net-next 0/3] mlxsw: Minor cleanup · Jiri Pirko <jiri@resnulli.us> · 2017-06-04
[patch net-next 1/3] mlxsw: spectrum: Tidy up header file · Jiri Pirko <jiri@resnulli.us> · 2017-06-04
[patch net-next 2/3] mlxsw: Fix typo inside enumeration · Jiri Pirko <jiri@resnulli.us> · 2017-06-04
[patch net-next 3/3] mlxsw: spectrum_router: Align RIF index allocation with existing code · Jiri Pirko <jiri@resnulli.us> · 2017-06-04
RE: [patch net-next 3/3] mlxsw: spectrum_router: Align RIF index allocation with existing code · David Laight <hidden> · 2017-06-06
Re: [patch net-next 0/3] mlxsw: Minor cleanup · David Miller <davem@davemloft.net> · 2017-06-05

RE: [patch net-next 3/3] mlxsw: spectrum_router: Align RIF index allocation with existing code

From: David Laight <hidden>
Date: 2017-06-06 09:11:59

From: Jiri Pirko

Sent: 04 June 2017 15:54
The way we usually allocate an index is by letting the allocation
function return an error instead of an invalid index.

...

-static int mlxsw_sp_avail_rif_get(struct mlxsw_sp *mlxsw_sp)
+static int mlxsw_sp_rif_index_alloc(struct mlxsw_sp *mlxsw_sp, u16 *p_rif_index)

You typically get much better code from returning an invalid index.
This is why PTR_ERR() exists.

	David