RE: [PATCH net-next] net: phy: smsc: Implement PHY statistics
flat view
From: Woojung.Huh@microchip.com
Date: 2017-06-02 23:35:09
Andrew,
quoted hunk ↗ jump to hunk
static int smsc_phy_probe(struct phy_device *phydev) { struct device *dev = &phydev->mdio.dev;@@ -206,6 +258,11 @@ static struct phy_driver smsc_phy_driver[] = { .ack_interrupt = smsc_phy_ack_interrupt, .config_intr = smsc_phy_config_intr, + /* Statistics */ + .get_sset_count = smsc_get_sset_count, + .get_strings = smsc_get_strings, + .get_stats = smsc_get_stats, +
...
quoted hunk ↗ jump to hunk
+ /* Statistics */ + .get_sset_count = smsc_get_sset_count, + .get_strings = smsc_get_strings, + .get_stats = smsc_get_stats, +
...
quoted hunk ↗ jump to hunk
+ /* Statistics */ + .get_sset_count = smsc_get_sset_count, + .get_strings = smsc_get_strings, + .get_stats = smsc_get_stats, +
...
quoted hunk ↗ jump to hunk
+ /* Statistics */ + .get_sset_count = smsc_get_sset_count, + .get_strings = smsc_get_strings, + .get_stats = smsc_get_stats, +
Just cosmetic thing. How about aligning with other members in structure like
quoted hunk ↗ jump to hunk
+ .get_sset_count = smsc_get_sset_count, + .get_strings = smsc_get_strings, + .get_stats = smsc_get_stats,
Reviewed-By: Woojung Huh <Woojung.Huh@microchip.com>