Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing
From: David Miller <davem@davemloft.net>
Date: 2017-05-31 16:32:06
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2017-05-31 16:32:06
Also in:
lkml
From: Andy Shevchenko <redacted> Date: Tue, 30 May 2017 21:48:05 +0300
On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka [off-list ref] wrote:quoted
Some cleanups of the way we probe DMI platforms in the driver. Reduces a bit of open-coding and makes the logic easier reusable for any potential DMI platform != Quark. Tested on IOT2000 and Galileo Gen2.So, for patches 1-4, Reviewed-by: Andy Shevchenko <redacted> I'm not convinced that patch 6 is needed, so, my vote is not to include it. Patch 5 I would like to review later. Main problem to me is {-1, -1}. It looks non-standard and feels not good. I'll try to think on the solution.
Ok, so at a minimum I'm expecting another respin of this.