Re: [net-wireless-orinoco] question about potential null pointer dereference
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-05-30 19:37:08
Also in:
linux-wireless, lkml
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-05-30 19:37:08
Also in:
linux-wireless, lkml
Hi,
The issue here is that line 56 implies that pointer tfm_michael might be NULL. If this is the case, there is a potential NULL pointer dereference at line 52 once pointer tfm_michael is indirectly dereferenced inside macro SHASH_DESC_ON_STACK(). My question is if there is any chance that pointer tfm_michael might be NULL when calling macro SHASH_DESC_ON_STACK() ? I'm trying to figure out if this is a false positive or something that needs to be fixed somehow.
Look, if you're just sending the coverity reports to the list without reflecting and researching them, that's not actually useful - we can look at them ourselves. It took me at most a few minutes to figure this one out, so please just do the same, look at the code, and figure out what the right answer is here. johannes