Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions
From: SF Markus Elfring <hidden>
Date: 2017-05-22 10:50:51
Also in:
kernel-janitors, kvm, lkml
From: SF Markus Elfring <hidden>
Date: 2017-05-22 10:50:51
Also in:
kernel-janitors, kvm, lkml
quoted
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdfPlease include an actual explanation for this change instead of linking to slides.
Do you care for a bit of code size reduction by removal of questionable error messages?
Why are you trying to get rid of memory allocation failure messages?
Do you find information from a Linux allocation failure report sufficient for any function implementations here?
quoted
+++ b/drivers/vhost/scsi.c@@ -417,5 +417,4 @@ vhost_scsi_allocate_evt(struct vhost_scsi *vs, if (!evt) { - vq_err(vq, "Failed to allocate vhost_scsi_evt\n");#define vq_err(vq, fmt, ...) do { \ pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \ if ((vq)->error_ctx) \ eventfd_signal((vq)->error_ctx, 1);\ } while (0) You silently dropped the eventfd_signal() call.
Do you prefer to preserve this special error handling then? Regards, Markus