Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries
From: David Ahern <hidden>
Date: 2017-05-16 23:27:51
Also in:
lkml
On 5/13/17 3:30 AM, Mickaël Salaün wrote:
On 13/02/2017 02:43, David Ahern wrote:quoted
On 2/12/17 2:23 PM, Mickaël Salaün wrote:quoted
diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore new file mode 100644 index 000000000000..a7562a5ef4c2 --- /dev/null +++ b/samples/bpf/.gitignore@@ -0,0 +1,32 @@ +fds_example +lathist... Listing each target is going to be a PITA to maintain. It would be better to put targets into a build directory (bin?) and ignore the directory.It would require a lot of modifications to the Makefile and more complexity. It seems much more simple for everyone to stick to a simple gitignore file easily maintainable: $ awk '$1 == "hostprogs-y" { print $3 }' < Makefile > .gitignore Alexei, Daniel, what do you think about this? Do you want me to send a v2 with the new tests?
The problem stems from the fact that bpf samples do not really fall into the 'hostprogs' category (see "4 Host Program support" in Documentation/kbuild/makefiles.txt). Fixing samples/bpf to not rely on it is the better long term solution. Building of tools/ for example does not rely on it so there is an existing example of leveraging kernel headers without the overhead.