Thread (2 messages) flat view 2 messages, 2 authors, 2017-05-11

Re: [PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd

From: David Miller <davem@davemloft.net>
Date: 2017-05-11 16:17:59
Also in: kernel-janitors, lkml

From: Colin King <redacted>
Date: Tue,  9 May 2017 17:19:42 +0100
From: Colin Ian King <redacted>

Currently rcode is being initialized to NX_RCODE_SUCCESS and later it
is checked to see if it is not NX_RCODE_SUCCESS which is never true. It
appears that there is an unintentional missing assignment of rcode from
the return of the call to netxen_issue_cmd() that was dropped in
an earlier fix, so add it in.

Detected by CoverityScan, CID#401900 ("Logically dead code")

Fixes: 2dcd5d95ad6b2 ("netxen_nic: fix cdrp race condition")
Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help