Thread (1 message) 1 message, 1 author, 2017-05-11

Re: [PATCH] libertas: Avoid reading past end of buffer

From: Kalle Valo <hidden>
Date: 2017-05-11 03:46:27
Also in: linux-wireless, lkml

Joe Perches [off-list ref] writes:
unrelated trivia:

lbs_deb_enter is used incorrectly here at
function exit as both enter and leave calls.

That type of copy/paste defect may be common.

$ git grep -w lbs_deb_enter | wc -l
148
$ git grep -w lbs_deb_leave | wc -l
71

One would expect these numbers to be the same.

Another option would be to delete all these
calls as ftrace function tracing works well.
Yeah, deleting all the enter/exit calls would be better.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help