Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

On 2017-05-08 14:02, Joao Pinto wrote:

Às 12:56 PM de 5/8/2017, Andy Shevchenko escreveu:

quoted

On Mon, May 8, 2017 at 2:40 PM, Joao Pinto [off-list ref] wrote:

quoted

Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu:

quoted

On Mon, May 8, 2017 at 1:42 PM, Joao Pinto [off-list ref] wrote:

quoted

Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu:

quoted

On Mon, May 8, 2017 at 12:54 PM, Joao Pinto [off-list ref] wrote:

quoted

Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu:

quoted

quoted

[   44.374161] stmmac_dvr_probe <<< 0 0

Ok, so this is the cause of the problem. The driver is geting 0 for real RX and
TX queues.

Your setup uses standard DT parsing from stmmac_platform or a custom one?

If you are using stmmac_probe_config_dt():
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_torvalds_linux.git_tree_drivers_net_ethernet_stmicro_stmmac_stmmac-5Fplatform.c-23n363&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=s2fO0hii0OGNOv9qQy_HRXy-xAJUD1NNoEcc3io_kx0&m=fJQj7RiT2sksJYOAZ9VSJUDnxPR7RlE6Fw_cTV0_Mqc&s=KhdAPUtP0twDkibE89cLYs8JjnxEvBgav5uf08WL_e8&e= 

You will find a function named stmmac_mtl_setup() being called:
https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_torvalds_linux.git_tree_drivers_net_ethernet_stmicro_stmmac_stmmac-5Fplatform.c-23n492&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=s2fO0hii0OGNOv9qQy_HRXy-xAJUD1NNoEcc3io_kx0&m=fJQj7RiT2sksJYOAZ9VSJUDnxPR7RlE6Fw_cTV0_Mqc&s=rTxn0fwdudwq9XAquH60xNHN538KBQ6_n4wODdLoyA0&e= 

In this function, the number of RX and TX queues is being set to 1 by default.

Ah-ha, now I know how it's happened.
You forget to update all setup() hooks in PCI bus driver :-)

I will prepare a fix.
Just tell me should I put Fixes tag or not? And if yes, what commit
should I refer to?

Great, you can use this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c?id=26d6851fd24ed5d88580d66b4c8384947d5ca29b

Thanks!

Joao

Perfect, looking forward to try out a fix. Thanks, folks!

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux