Thread (9 messages) 9 messages, 5 authors, 2017-05-31

RE: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option()

From: YUAN Linyu <hidden>
Date: 2017-05-31 00:29:07

quoted
-----Original Message-----
From: David Ahern [mailto:dsahern@gmail.com]
Sent: Tuesday, May 30, 2017 11:42 AM
To: Joe Perches; David Miller; cugyly@163.com
Cc: netdev@vger.kernel.org; YUAN Linyu
Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of
__ndisc_fill_addr_option()

On 5/29/17 9:41 PM, Joe Perches wrote:
quoted
On Mon, 2017-05-29 at 23:30 -0400, David Miller wrote:
quoted
From: yuan linyu <redacted>
Date: Sat, 27 May 2017 06:00:52 +0800
quoted
From: yuan linyu <redacted>

Signed-off-by: yuan linyu <redacted>
Applied, thanks.
OK, but is it really safe though?

Could "space" (an int) ever be negative after
subtracting "pad" and "data_len"?
that function should be converted to skb_put_zero once it hits net-next.
I will check it
I can't find skb_put_zero
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help