Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-05-30 17:12:29
On Sat, 27 May 2017 10:14:36 -0400 Vladislav Yasevich [off-list ref] wrote:
+static const char *netdev_events[] = {"NONE",
+ "REBOOT",
+ "FEATURE CHANGE",
+ "BONDING FAILOVER",
+ "NOTIFY PEERS",
+ "RESEND IGMP",
+ "BONDING OPTION"};
Overall this looks fine, I will pickup the if_link.h from net-next.
One stylistic change.
Please add simple line break, and initialize by value:
static const char *netdev_events[] = {
[IFLA_EVENT_NONE] = "NONE",
...
Do you want some prefix or bounding around the event output?
Also a little concerned that the output format change may break some program
could the new output be at the end of the line?