Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-05-22 21:04:58
Also in:
linux-wireless
Possibly related (same subject, not in this thread)
- 2017-05-23 · Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi · Arend Van Spriel <hidden>
- 2017-05-22 · Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi · Arend van Spriel <arend.vanspriel@broadcom.com>
- 2017-05-22 · Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi · Johannes Berg <hidden>
- 2017-05-22 · 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi · Sander Eikelenboom <hidden>
Hi Arend, Sorry, I forgot that the original message wasn't Cc'ed to the wireless list, only netdev.
quoted hunk ↗ jump to hunk
+++ b/net/wireless/scan.c@@ -322,9 +322,7 @@ static void cfg80211_del_sched_scan_req(structcfg80211_regi { struct cfg80211_sched_scan_request *pos; - ASSERT_RTNL(); - - list_for_each_entry(pos, &rdev->sched_scan_req_list, list) { + list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list) {
[snip] This looks fine, but perhaps in the above we should have some kind of locking assertion, e.g. WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held()); johannes