Thread (5 messages) flat view 5 messages, 4 authors, 2017-05-21

Re: [PATCH net-next v5] net: ipv6: fix code style error and warning of ndisc.c

From: Joe Perches <joe@perches.com>
Date: 2017-05-21 21:14:42

On Sun, 2017-05-21 at 12:54 -0400, David Miller wrote:
From: David Ahern <redacted> Date: Sun, 21 May 2017 10:17:47 -0600
quoted
On 5/21/17 10:05 AM, Joe Perches wrote:
quoted
But really, why bother?

Just because checkpatch bleats some message doesn't
mean it _has_ to be fixed.

Please strive to make the code more readable and
intelligible for _humans_.  Compilers don't care.
+1

broad cleanups like this make 'git blame' harder to use to find root causes.
I don't have any issue with broad cleanups and I think
the git blame argument is overblown.

If and when broad cleanups are done, it's best if there
is some other concurrent desire to improve logic, reduce
object code size, and/or other code refactoring other
than mere whitespace changes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help