Thread (1 message) 1 message, 1 author, 2017-05-18

Re: [PATCH] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

From: Peter Dawson <hidden>
Date: 2017-05-18 02:49:03

quoted
This fix addresses two problems in the way the DSCP field is
formulated on the  encapsulating header of IPv6 tunnels.
This fix addresses Bug 195661.
https://bugzilla.kernel.org/show_bug.cgi?id=195661

1) The IPv6 tunneling code was manipulating the DSCP field of the
encapsulating  packet using the 32b flowlabel. Since the flowlabel is
only the lower 20b it  was incorrect to assume that the upper 12b
containing the DSCP and ECN fields  would remain intact when
formulating the encapsulating header. This fix  handles the 'inherit'
and 'fixed-value' DSCP cases explicitly using the extant  dsfield u8 variable.

2) The use of INET_ECN_encapsulate(0, dsfield) in ip6_tnl_xmit was
incorrect  and resulted in the DSCP value always being set to 0.
---
 net/ipv6/ip6_gre.c    | 18 ++++++++++--------
 net/ipv6/ip6_tunnel.c | 28 +++++++++++++++++-----------
 2 files changed, 27 insertions(+), 19 deletions(-)
This patch looks correct, but has trivial style issues like using spaces instead of tabs and other junk.  Please run checkpatch.pl, look at the results and resubmit.
Thanks.  I've run checkpatch.pl over this updated file with no errors.
Regards
Peter

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help