Re: [PATCH v3 net-next 4/7] net: add new control message for incoming HW-timestamped packets
From: Richard Cochran <richardcochran@gmail.com>
Date: 2017-05-17 17:21:15
From: Richard Cochran <richardcochran@gmail.com>
Date: 2017-05-17 17:21:15
On Wed, May 17, 2017 at 10:11:50AM -0400, Soheil Hassas Yeganeh wrote:
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar [off-list ref] wrote:quoted
+/* SCM_TIMESTAMPING_PKTINFO control message */ +struct scm_ts_pktinfo { + __u32 if_index; + __u32 pkt_length; +}; +Given that this structure can change in the future, it might be worth considering using TLVs (e.g., netlink attributes), similar to what tcp_get_timestamping_opt_stats() does. This would simplify adding/removing fields to/from the control message.
[ BTW, please trim your replies. ] Personally, I dislike TLVs. Alternatively, you could add some reserved fields for future use. Thanks, Richard