Re: [PATCH net] tcp: init tcp_options before using it.

On Mon, May 08, 2017 at 07:49:23AM -0700, Eric Dumazet wrote:

On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote:

quoted

I searched 4308fc58dced ("tcp: Document use of undefined variable") in
archive list, but did not find the thread. So I'm not sure why we only
add a description about un-initialized value.

Even we don't use tmp_opt.sack_ok, I think it would be more safe to
initialize the value before using it. Just as other caller did.

Patch is not needed at all.

Comment and code are pretty clear.

This part of the code uses a generic function ( tcp_parse_options()) to
decode TCP options, but we are only caring about TS one.

OK, got it. Thanks for the explanation and sorry for the inconvenience.

Best Regards
Hangbin