Thread (14 messages) flat view 14 messages, 4 authors, 2017-05-02

Re: [PATCH net-next iproute2 1/3] netlink: import netlink message parsing from kernel

From: David Miller <davem@davemloft.net>
Date: 2017-05-02 17:00:36

From: David Ahern <redacted>
Date: Tue, 2 May 2017 10:51:23 -0600
On 5/2/17 9:25 AM, Stephen Hemminger wrote:
quoted
Please either use existing netlink attribute code in libnetlink.h
(rta_getattr_u32 etc) or use libmnl like devlink.
All of the existing rta_ functions take a struct rta_attr; netlink
messages use struct nlattr. It's just wrong to use rta functions for
netlink messages.
Agreed.
There is no existing parse function for nlattr. There is no existing
validate function - for nlattr or rta_attr. So I do not see any overlap
with existing code.
Also agreed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help