Thread (14 messages) 14 messages, 6 authors, 2017-05-01

Re: [PATCH net-next] samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel

From: Jesper Dangaard Brouer <hidden>
Date: 2017-05-01 09:10:03

On Sun, 30 Apr 2017 17:46:13 -0600
David Ahern [off-list ref] wrote:
On 4/28/17 3:40 PM, Jesper Dangaard Brouer wrote:
quoted
[...]  
quoted
diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c
index 0d449d8032d1..d4433a47e6c3 100644
--- a/samples/bpf/bpf_load.c
+++ b/samples/bpf/bpf_load.c
@@ -563,7 +563,7 @@ struct ksym *ksym_search(long key)
 	return &syms[0];
 }
 
-int set_link_xdp_fd(int ifindex, int fd)
+int set_link_xdp_fd(int ifindex, int fd, int flags)  
Shouldn't the flags be a unsigned int, actually a __u32 ?
  
sure. I'll send a patch
I found another bug in xdp_tx_iptunnel ... I'll send a patch for both issues.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help