Thread (15 messages) 15 messages, 2 authors, 2017-06-01

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

From: Johan Hovold <johan@kernel.org>
Date: 2017-04-26 10:36:49
Also in: linux-wireless, lkml

On Wed, Apr 19, 2017 at 01:24:31AM +0200, Samuel Ortiz wrote:
On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote:
quoted
On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
quoted
This started out with the observation that the nfcmrvl_uart driver
unconditionally dereferenced the tty class device despite the fact that
not every tty has an associated struct device (Unix98 ptys). Some
further changes were needed in the common nfcmrvl code to fully address
this, some of which also incidentally fixed a few related bugs (e.g.
resource leaks in error paths).

While fixing this I stumbled over a regression in NFC core that lead to
broken registration error paths and misnamed workqueues.

Note that this has only been tested by configuring the n_hci line
discipline for different ttys without any actual NFC hardware connected.
quoted
Johan Hovold (8):
  NFC: fix broken device allocation
  NFC: nfcmrvl_uart: add missing tty-device sanity check
  NFC: nfcmrvl: do not use device-managed resources
  NFC: nfcmrvl: use nfc-device for firmware download
  NFC: nfcmrvl: fix firmware-management initialisation
  NFC: nfcmrvl_uart: fix device-node leak during probe
  NFC: nfcmrvl_usb: use interface as phy device
  NFC: nfcmrvl: allow gpio 0 for reset signalling
Any chance of getting these into 4.12, Samuel?
I have yours and Mark Greer patchset pending. I'll push them to nfc-next
and see if I can send another pull request to Dave by the end of this
week.
Any progress on this now that we got another week?

Thanks,
Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help