Thread (23 messages) 23 messages, 6 authors, 2017-04-28

Re: [PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-04-28 15:42:15

On 04/28/2017 07:14 AM, David Miller wrote:
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 28 Apr 2017 14:10:48 +0800
quoted
The commit 6d684e54690c ("rhashtable: Cap total number of entries
to 2^31") breaks rhashtable users that do not set max_size.  This
is because when max_size is zero max_elems is also incorrectly set
to zero instead of 2^31.

This patch fixes it by only lowering max_elems when max_size is not
zero.

Fixes: 6d684e54690c ("rhashtable: Cap total number of entries to 2^31")
Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Reported-by: kernel test robot <redacted>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Herbert
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help