Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

Tue, Apr 11, 2017 at 10:29:52AM CEST, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org wrote:

On Tue, 2017-04-11 at 10:13 +0200, Jiri Pirko wrote:

quoted

Tue, Apr 11, 2017 at 09:29:18AM CEST, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org
wrote:

quoted

On Tue, 2017-04-11 at 09:19 +0200, Jiri Pirko wrote:

quoted

quoted

+	NUM_NLMSGERR_ATTRS,

According to the rest of the uapi, this should be rather named:
	__NLMSGERR_ATTR_MAX

nl80211 uses NUM_ so I guess that's a matter of convention, but I
can
change that I guess.

Please do.

No further comments on any other parts of the patch(es)? :)

I didn't found anything aside the narrow descriptions- you have it like
that in 4 out of 5 patches :)

I don't want to be resending all the time, so I guess I'll wait. For
now, all code is in the nl-err branch in mac80211-next.

johannes