Re: [PATCH iproute2] man: fix man page warnings
flat view
From: Phil Sutter <phil@nwl.cc>
Date: 2017-04-05 14:56:25
On Sun, Mar 26, 2017 at 09:11:14PM +0200, Alexander Alemayhu wrote:
While generating PDFs from the man pages, I saw the warning below from
several files. Compared the tc-matchall.8 with bridge.8 and used .RI
instead of .R. It should have no effect on the man page rendering.
`R' is a string (producing the registered sign), not a macro.
Signed-off-by: Alexander Alemayhu <redacted>I know this has been applied already, but let me get this straight: People using '.R' try to force "normal" font, like for every second parameter to '.IR' but in fact they could just leave the macro away since lines starting without any macro will get normal font settings anyway. With this in mind, I see better solutions for the changes in this patch: [...]
quoted hunk ↗ jump to hunk
@@ -20,7 +20,7 @@ flower \- flow based traffic control filter .B indev .IR ifname " | " .BR skip_sw " | " skip_hw -.R " | { " +.RI " | { "
Just merge this into previous line:
| .BR skip_sw " | " skip_hw " | {"
Note the missing space at the end, as that comes for free anyway. :)
[...]quoted hunk ↗ jump to hunk
@@ -13,7 +13,7 @@ IFE - encapsulate/decapsulate metadata .IR SMAC " ] " .RB "[ " type .IR TYPE " ] " -.R "[ " +.RI "[ "
Same here: | .IR TYPE " ] [" [...]
quoted hunk ↗ jump to hunk
@@ -7,7 +7,7 @@ matchall \- traffic control filter that matches every packet .ti -8 .BR tc " " filter " ... " matchall " [ " .BR skip_sw " | " skip_hw -.R " ] [ " +.RI " ] [ "
And here as well: | .BR skip_sw " | " skip_hw " ] [" Cheers, Phil