Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues
From: Joao Pinto <hidden>
Date: 2017-03-31 10:44:45
Also in:
lkml
Às 11:14 AM de 3/31/2017, Joao Pinto escreveu:
Às 6:48 PM de 3/30/2017, David Miller escreveu:quoted
From: Thierry Reding <redacted> Date: Thu, 30 Mar 2017 16:34:36 +0200quoted
On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:quoted
On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote:quoted
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 28 Mar 2017 11:48:21 +0200quoted
A driver must not access the two fields directly but should instead use the helper functions to set the values and keep a consistent internal state: ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe': ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'? Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration") Signed-off-by: Arnd Bergmann <arnd@arndb.de>Applied.This break my revert patch. (since it patch ("net: stmmac: enable multiple buffers"). Since dwmac-sunxi is still broken, what can I do ? send two revert patch ? or adapt the reverting patch.Have you tried if the kcalloc() patch I sent on Tuesday fixes things the issues introduced by the multiple buffers patch? Niklas reported that it restores functionality on his setup.I think he said yesterday that he did indeed test all of your patches and it did not fix things for him. http://marc.info/?l=linux-kernel&m=149076922813085&w=2 I am going to revert the enable multiple buffers commit, and I would ask that all involved parties work together in the background to resolve all of this.
@David: Could you please create a branch in your git tree for us to work on it until the multiple buffers get stable for everyone? This way the patches could circulate in the mailing-list with a different target, like stmmac-next or similar. What do you think? Joao
quoted
Thank you.@David: Agreed. @Corentin: Please check if the DMA Engine is well configured and if the dma rx/tx has started. This is done by dumping the DMA Registers. Please also check the MAC related registers and dump them in order to have a clear picture if the IP is being well configured. This is critial to analise what's hapenning in your setup. Joao